Enabled directive not changing to yes when applying config.

Plural

I have a Config that I use to enable jobs in bulk and I have another to disable jobs in bulk. The disable one it's working but the enable one it's not. This was working in the past.

Steps to reproduce:

Create a Config, e.g. "Enable Jobs" like this:

Notice the "Job disabled" description
Try to apply the config to a disabled job

As you can see, the description directive is applied but the enabled directive is not.
Create another config, e.g. "Disable jobs" but let the Enabled directive unchecked and put something like "Job disabled" in the description directive.
Try to apply the config to a enabled job. This will work as espected.

Best regards,
Rui

gani

Hi Rui,

Thanks for your detailed report. You found an intersting use case that in Bacularis is normal behaviour in the Bacula configuration context but in the Config/Pattern this takes on a new meaning.

This is about directive fields and its default values. Normally in any configuration field if the field is modified and the value is different than default, this value is saved. In case this checkbox type if default checkbox value is true (enabled) then we don't save it because it is unmodified (value is default value). Unchecking this checkbox causes that it is modified. This is because on your side applying the config with disabled checkbox worked, but applying config with enabled not.

The same situation is with the opposite scenario with saving values if the default value is false (unchecked) and we want to save in Config this false value.

For other fields (non-checkboxes) this is general issue with supporting saved in the Config value that is default field value. For example, in text field default directive XYZ value is abc and we want to save in the Config XYZ=abc.

So, I think we need to implement a way of supporting in Configs/Patterns values if we want to save in Config the value that is the same as default value. For Bacula configuration part this behavior is fine, but in Configs/Patterns not.

Thanks for finding it.

Best regards,
Marcin Haba (gani)

Plural

Hi @gani,

I thing that from the Bacula point of view, the default value is to be applyed when the directive does not exist in the configuration. If the dirietive exist, the value must be the one in the directive even if it's the same as the default. I thing that a good way to go in the configs case, it's to apply the values if the directive exist, otherwise don't apply the values if the value it's the default.

Best regards,
Rui

gani

Hi Rui,

Thanks for sharing your thoughts.

Plural I thing that from the Bacula point of view, the default value is to be applyed when the directive does not exist in the configuration.

Sure. The key to understand here is that Configs/Patterns are not Bacula concept but Bacularis concept. The problem here is not applying the configuration to Bacula but writing default values in Configs. Configs are abstract entities for which question if directive exists/if directive does not exist is not the right question because Configs exist regardless Bacula configuration.

In other words, the question is for writing Configs, not for applying Configs. This is why I wrote that in case Configs/Patterns this topic takes on a new meaning.

Best regards,
Marcin Haba (gani)

Plural

Hi Marcin,

Thank you for the clarification.
I thing I understand now. Thats why we can not remove this on/off directives from the Configs.

Best regards,
Rui